fix(web): derive greeting name from email, not the userId hash - #19
Merged
Conversation
When no custom call-me/display name is set (e.g. a fresh device with no local settings), the empty-state greeting fell back to principal.userId, which is an opaque hash and rendered as "Good evening, 6b72871a". Prefer principal.email so it derives a human name available on every device. Note: the custom call-me name is still device-local (localStorage). True cross-device consistency is the Track A /profile (account_profiles. display_name) slice; wire apps/web to it once that backend lands. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a device with no local call-me/display name set, the chat empty-state greeting fell back to
principal.userId(an opaque hash), rendering as "Good evening, 6b72871a" on mobile while desktop showed the custom name. Preferprincipal.emailfor the fallback so it derives a human-readable name available on every device.Scope / follow-up
This fixes the ugly hash only. The custom "call me" name is still per-device (
localStorage), so it won't match across devices until it's account-bound. True cross-device sync is the Track A Settings slice (account_profiles.display_name+GET/PATCH /profile, perdocs/TRACK_A_SETTINGS_SPEC.md); wiringapps/webto that endpoint is the planned follow-up once the backend lands.Typecheck passes.
🤖 Generated with Claude Code